test(gates): add tests for 5 gate scripts (untested 40→35) - #1078
Merged
Merged
Conversation
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 30, 2026
Adds a fail-capable test for each of check-uuid-v7, check-mustfile-structure, check-language-guide, run-shell-test-suite and check-descriptile-policy (60 assertions; each gate shown able to fail for the right reason). gate-scripts-without-tests is re-measured at 35 and its count and ceiling are lowered 40→35, so the ratchet tightens rather than merely holding. Fixtures that the real uuid/descriptile gates would flag are assembled at runtime, because the scripts/*.sh pathspec also covers scripts/tests/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WPSJ7fBhVAMcpSffCBWUDo Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
hyperpolymath
force-pushed
the
debt/pay-down-ratchet-2026-09-30
branch
from
September 30, 2026 14:07
036970b to
072e91c
Compare
hyperpolymath
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pays the gate-scripts-without-tests debt down by adding real, fail-capable tests for five gate scripts. The count and ceiling both drop from 40 to 35, measured from the Debtfile's own probe.
scripts/tests/uuid-v7-test.shcheck-uuid-v7.shscripts/tests/mustfile-structure-test.shcheck-mustfile-structure.shscripts/tests/language-guide-test.shcheck-language-guide.shscripts/tests/shell-test-suite-test.shrun-shell-test-suite.shscripts/tests/descriptile-policy-test.shcheck-descriptile-policy.shEach test is shown to fail for the right reason, not just to pass: re-introducing each defect in the gate turns the matching assertion red. The uuid and descriptile gates scan
scripts/*.sh, and that pathspec also coversscripts/tests/. So the fixtures those gates would flag are assembled at runtime and never appear literally in the test files.Rebased onto
3a845452(#1067). #1067 already landed the doc→adoc conversion and the 2→1 and 43→40 ceilings, so this PR now carries only the five tests and the 40→35 reduction.Verification, run locally on the rebased head:
check-debtfile-structure.sh: rc=0check-debt-ratchet.sh 3a845452:LOWERED gate-scripts-without-tests: 40 -> 35, rc=0🤖 Generated with Claude Code
https://claude.ai/code/session_01WPSJ7fBhVAMcpSffCBWUDo